Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for installation of everest_models jobs #9116

Closed
wants to merge 1 commit into from
Closed

Add test for installation of everest_models jobs #9116

wants to merge 1 commit into from

Conversation

verveerpj
Copy link
Contributor

Issue
Add a test to check if everest_models jobs are installed properly.

Approach
Read which models are available in everest_modesls and check if they turn up in the ErtConfig as plugins.

blocked by equinor/everest-models#75

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@verveerpj verveerpj added blocked release-notes:skip If there should be no mention of this in release notes labels Oct 31, 2024
@verveerpj verveerpj self-assigned this Oct 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (70e85a7) to head (e0178d9).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9116   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files         350      350           
  Lines       21778    21778           
=======================================
  Hits        19758    19758           
  Misses       2020     2020
Flag Coverage Δ
cli-tests 39.04% <ø> (+<0.01%) ⬆️
gui-tests 71.68% <ø> (ø)
performance-tests 49.24% <ø> (+0.01%) ⬆️
unit-tests 79.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@verveerpj verveerpj marked this pull request as draft October 31, 2024 14:13
@verveerpj verveerpj closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@verveerpj verveerpj

Labels
blocked release-notes:skip If there should be no mention of this in release notes
Projects
SCOUT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@verveerpj @codecov-commenter